From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()
Date: Mon, 06 Nov 2017 10:06:15 +0000 [thread overview]
Message-ID: <2d650d87-034c-d05b-b3aa-f689f25ab184@microchip.com> (raw)
In-Reply-To: <8d297cae-5dd1-d345-8d9d-9bf3ec32d4f8@users.sourceforge.net>
On 06/11/2017 at 10:32, SF Markus Elfring wrote:
>> Sorry but NACK: the message was malformed and resulted in the
>> duplication of the error log that you spotted.
>>
>> The proper way to fix this is to modify the second occurrence of this message.
>
> * Would you like to achieve that a corresponding message will mention
> anything around a property “atmel,dmacon” (instead of “bits-per-pixel”)?
Yes: that would actually fix the wrong log message.
> * Can it make sense to adjust the used message format then?
In another patch, why not... Beware about the added complexity though.
Regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2017-11-06 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 13:10 [PATCH] video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init() SF Markus Elfring
2017-11-06 8:40 ` Nicolas Ferre
2017-11-06 8:53 ` Dan Carpenter
2017-11-06 9:00 ` SF Markus Elfring
2017-11-06 9:53 ` Dan Carpenter
2017-11-06 9:32 ` SF Markus Elfring
2017-11-06 10:06 ` Nicolas Ferre [this message]
2017-11-06 18:14 ` [PATCH v2] video: atmel_lcdfb: Use unique error messages " SF Markus Elfring
2017-11-06 18:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d650d87-034c-d05b-b3aa-f689f25ab184@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox