From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 08 Jan 2017 21:50:25 +0000 Subject: [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() Message-Id: <304ae7a7-bc51-83d7-2a6b-844cdf4c346f@users.sourceforge.net> List-Id: References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> In-Reply-To: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Shawn Lin , Ulf Hansson , Wolfram Sang Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Sun, 8 Jan 2017 21:43:12 +0100 * The script "checkpatch.pl" pointed information out like the following. WARNING: Prefer kcalloc over kzalloc with multiply Thus fix the affected source code place. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mmc/core/mmc_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c index 294d3c675734..cb4750de2720 100644 --- a/drivers/mmc/core/mmc_test.c +++ b/drivers/mmc/core/mmc_test.c @@ -360,8 +360,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz, if (!mem) return NULL; - mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs, - GFP_KERNEL); + mem->arr = kcalloc(max_segs, sizeof(*mem->arr), GFP_KERNEL); if (!mem->arr) goto out_free; -- 2.11.0