public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [modsign:for-rusty 1/1] include/linux/moduleloader.h:48:2: error: 'mod' undeclared (first use in
Date: Thu, 19 Jul 2012 11:37:20 +0000	[thread overview]
Message-ID: <31265.1342697840@warthog.procyon.org.uk> (raw)
In-Reply-To: <20120718163652.GA9580@localhost>

Fengguang Wu <fengguang.wu@intel.com> wrote:

> I cannot quite understand this error. The problem is that I've just
> setup the blackfin cross compile, and hence it might be an old bug, or
> even some problem in my build setup..
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-modsign.git for-rusty
> head:   b64582d2ab63dabc1b2bf05143900c8b2ff4b4ee
> commit: b64582d2ab63dabc1b2bf05143900c8b2ff4b4ee [1/1] Make most arch asm/module.h files use asm-generic/module.h
> config: blackfin-BF526-EZBRD_defconfig (attached as .config)
> 
> All related error/warning messages:
> 
> In file included from arch/blackfin/kernel/module.c:9:0:
> include/linux/moduleloader.h: In function 'apply_relocate':
> include/linux/moduleloader.h:48:2: error: 'mod' undeclared (first use in this function)
> include/linux/moduleloader.h:48:2: note: each undeclared identifier is reported only once for each function it appears in

pr_err() is the problem.  If you're in a file that defines pr_fmt then it will
use that.  At the top of arch/blackfin/kernel/module.c:

	#define pr_fmt(fmt) "module %s: " fmt, mod->name

I guess you can't use pr_err() in header files.

David

      reply	other threads:[~2012-07-19 11:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 16:36 [modsign:for-rusty 1/1] include/linux/moduleloader.h:48:2: error: 'mod' undeclared (first use in thi Fengguang Wu
2012-07-19 11:37 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31265.1342697840@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox