* [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open()
@ 2017-12-09 11:49 Dan Carpenter
2017-12-09 17:09 ` Anton Ivanov
2017-12-11 9:33 ` Richard Weinberger
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-12-09 11:49 UTC (permalink / raw)
To: kernel-janitors
We need to unlock and restore IRQs on this error path.
Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index d1d53015d572..bb83a2d22ac2 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev)
struct vector_device *vdevice;
spin_lock_irqsave(&vp->lock, flags);
- if (vp->opened)
+ if (vp->opened) {
+ spin_unlock_irqrestore(&vp->lock, flags);
return -ENXIO;
+ }
vp->opened = true;
spin_unlock_irqrestore(&vp->lock, flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open()
2017-12-09 11:49 [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open() Dan Carpenter
@ 2017-12-09 17:09 ` Anton Ivanov
2017-12-11 9:33 ` Richard Weinberger
1 sibling, 0 replies; 3+ messages in thread
From: Anton Ivanov @ 2017-12-09 17:09 UTC (permalink / raw)
To: kernel-janitors
Thanks,
I guess I missed that one.
A.
On 09/12/17 11:49, Dan Carpenter wrote:
> We need to unlock and restore IRQs on this error path.
>
> Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index d1d53015d572..bb83a2d22ac2 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev)
> struct vector_device *vdevice;
>
> spin_lock_irqsave(&vp->lock, flags);
> - if (vp->opened)
> + if (vp->opened) {
> + spin_unlock_irqrestore(&vp->lock, flags);
> return -ENXIO;
> + }
> vp->opened = true;
> spin_unlock_irqrestore(&vp->lock, flags);
>
>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open()
2017-12-09 11:49 [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open() Dan Carpenter
2017-12-09 17:09 ` Anton Ivanov
@ 2017-12-11 9:33 ` Richard Weinberger
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2017-12-11 9:33 UTC (permalink / raw)
To: kernel-janitors
Anton,
Am Samstag, 9. Dezember 2017, 18:09:17 CET schrieb Anton Ivanov:
> Thanks,
>
> I guess I missed that one.
>
> A.
>
> On 09/12/17 11:49, Dan Carpenter wrote:
> > We need to unlock and restore IRQs on this error path.
> >
> > Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> > index d1d53015d572..bb83a2d22ac2 100644
> > --- a/arch/um/drivers/vector_kern.c
> > +++ b/arch/um/drivers/vector_kern.c
> > @@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev)
> >
> > struct vector_device *vdevice;
> >
> > spin_lock_irqsave(&vp->lock, flags);
> >
> > - if (vp->opened)
> > + if (vp->opened) {
> > + spin_unlock_irqrestore(&vp->lock, flags);
> >
> > return -ENXIO;
> >
> > + }
> >
> > vp->opened = true;
> > spin_unlock_irqrestore(&vp->lock, flags);
Please review/ack these patches.
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-11 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-09 11:49 [PATCH 1/2] um: vector_kern: Unlock on error in vector_net_open() Dan Carpenter
2017-12-09 17:09 ` Anton Ivanov
2017-12-11 9:33 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).