From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Colin Ian King <colin.king@canonical.com>
Cc: linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size
Date: Thu, 12 Oct 2017 16:30:32 +0000 [thread overview]
Message-ID: <3309966.vVeY8tZnvB@amdc3058> (raw)
In-Reply-To: <268158e3-00d6-b9c3-34a4-e8ce8e464276@canonical.com>
On Thursday, October 12, 2017 05:17:49 PM Colin Ian King wrote:
> On 12/10/17 17:17, Bartlomiej Zolnierkiewicz wrote:
> >
> > [ added dri-devel ML to cc: ]
> >
> > On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Don't populate the read-only const array post_divs on the stack,
> >> nstead make it static. Makes the object code smaller by 90 bytes:
> >>
> >> Before:
> >> text data bss dec hex filename
> >> 40231 8584 896 49711 c22f radeon_base.o
> >>
> >> After:
> >> text data bss dec hex filename
> >> 39914 8744 960 49618 c1d2 radeon_base.o
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >
> > Are these results obtained using the same compiler as the other patches
> > (gcc version 7.2.0, x86_64)?
>
> Yes, I forgot to annotate it.
Patch queued for 4.15 (with updated patch description), thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-10-12 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162@epcas2p3.samsung.com>
2017-09-19 21:32 ` [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size Colin King
2017-10-12 16:17 ` Bartlomiej Zolnierkiewicz
2017-10-12 16:17 ` Colin Ian King
2017-10-12 16:30 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3309966.vVeY8tZnvB@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox