[PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size

[PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Don't populate the read-only const array post_divs on the stack,
nstead make it static. Makes the object code smaller by 90 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  40231	   8584	    896	  49711	   c22f	radeon_base.o

After:
   text	   data	    bss	    dec	    hex	filename
  39914	   8744	    960	  49618	   c1d2	radeon_base.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/video/fbdev/aty/radeon_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
index 1e2ec360f8c1..8ad1643e7d1c 100644
--- a/drivers/video/fbdev/aty/radeon_base.c
+++ b/drivers/video/fbdev/aty/radeon_base.c
@@ -1534,7 +1534,7 @@ void radeon_write_mode (struct radeonfb_info *rinfo, struct radeon_regs *mode,
 static void radeon_calc_pll_regs(struct radeonfb_info *rinfo, struct radeon_regs *regs,
 				 unsigned long freq)
 {
-	const struct {
+	static const struct {
 		int divider;
 		int bitvalue;
 	} *post_div,
-- 
2.14.1

Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size

[Bartlomiej Zolnierkiewicz]

[ added dri-devel ML to cc: ]

On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the read-only const array post_divs on the stack,
> nstead make it static. Makes the object code smaller by 90 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   40231	   8584	    896	  49711	   c22f	radeon_base.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   39914	   8744	    960	  49618	   c1d2	radeon_base.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Are these results obtained using the same compiler as the other patches
(gcc version 7.2.0, x86_64)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size

[Colin Ian King]

On 12/10/17 17:17, Bartlomiej Zolnierkiewicz wrote:
> 
> [ added dri-devel ML to cc: ]
> 
> On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate the read-only const array post_divs on the stack,
>> nstead make it static. Makes the object code smaller by 90 bytes:
>>
>> Before:
>>    text	   data	    bss	    dec	    hex	filename
>>   40231	   8584	    896	  49711	   c22f	radeon_base.o
>>
>> After:
>>    text	   data	    bss	    dec	    hex	filename
>>   39914	   8744	    960	  49618	   c1d2	radeon_base.o
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Are these results obtained using the same compiler as the other patches
> (gcc version 7.2.0, x86_64)?

Yes, I forgot to annotate it.

Colin
> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size

[Bartlomiej Zolnierkiewicz]

On Thursday, October 12, 2017 05:17:49 PM Colin Ian King wrote:
> On 12/10/17 17:17, Bartlomiej Zolnierkiewicz wrote:
> > 
> > [ added dri-devel ML to cc: ]
> > 
> > On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Don't populate the read-only const array post_divs on the stack,
> >> nstead make it static. Makes the object code smaller by 90 bytes:
> >>
> >> Before:
> >>    text	   data	    bss	    dec	    hex	filename
> >>   40231	   8584	    896	  49711	   c22f	radeon_base.o
> >>
> >> After:
> >>    text	   data	    bss	    dec	    hex	filename
> >>   39914	   8744	    960	  49618	   c1d2	radeon_base.o
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > 
> > Are these results obtained using the same compiler as the other patches
> > (gcc version 7.2.0, x86_64)?
> 
> Yes, I forgot to annotate it.

Patch queued for 4.15 (with updated patch description), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics