From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bert Wesarg Date: Wed, 08 Apr 2009 11:39:18 +0000 Subject: Re: [PATCH 20/56] inflate: Remove void casts Message-Id: <36ca99e90904080439u7098d2feka5dd39f8ab6a470c@mail.gmail.com> List-Id: References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-13-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-14-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-15-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-16-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-17-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-18-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-19-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-20-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-21-git-send-email-jwjstone@fastmail.fm> In-Reply-To: <1239189748-11703-21-git-send-email-jwjstone@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jack Stone Cc: linux-kernel@vger.kernel.org, jeff@garzik.org, kernel-janitors@vger.kernel.org On Wed, Apr 8, 2009 at 13:21, Jack Stone wrote: > Remove uneeded void casts > > Signed-Off-By: Jack Stone > --- >  lib/inflate.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/inflate.c b/lib/inflate.c > index 1a8e8a9..4b672f9 100644 > --- a/lib/inflate.c > +++ b/lib/inflate.c > @@ -249,7 +249,7 @@ static void *malloc(int size) > >        malloc_ptr = (malloc_ptr + 3) & ~3;     /* Align */ > > -       p = (void *)malloc_ptr; > +       p = malloc_ptr; >        malloc_ptr += size; > >        if (free_mem_end_ptr && malloc_ptr >= free_mem_end_ptr) > @@ -481,7 +481,7 @@ DEBG1("3 "); >         z = 1 << j;             /* table entries for j-bit table */ > >         /* allocate and link in new table */ > -        if ((q = (struct huft *)malloc((z + 1)*sizeof(struct huft))) = > +        if ((q = malloc((z + 1)*sizeof(struct huft))) = >             (struct huft *)NULL) Thats an unneeded cast too. (After that, the NULL can move up one line.) Bert >         { >           if (h)