From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Date: Thu, 07 Jun 2018 19:46:15 +0000 Subject: Re: [PATCH] kselftest/cgroup: fix a signedness bug Message-Id: <37c8d24c-cfe5-ce86-8973-7b920112f59c@kernel.org> List-Id: References: <20180607083001.m4z4wjev6j3sc423@kili.mountain> <20180607125224.GA4302@castle> In-Reply-To: <20180607125224.GA4302@castle> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On 06/07/2018 06:52 AM, Roman Gushchin wrote: > On Thu, Jun 07, 2018 at 11:30:02AM +0300, Dan Carpenter wrote: >> "len" needs to be signed for the error handling to work. >> >> Signed-off-by: Dan Carpenter >> >> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c >> index b69bdeb4b9fe..1e9e3c470561 100644 >> --- a/tools/testing/selftests/cgroup/cgroup_util.c >> +++ b/tools/testing/selftests/cgroup/cgroup_util.c >> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len) >> return len; >> } >> >> -static ssize_t write_text(const char *path, char *buf, size_t len) >> +static ssize_t write_text(const char *path, char *buf, ssize_t len) >> { >> int fd; >> >> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key) >> int cg_write(const char *cgroup, const char *control, char *buf) >> { >> char path[PATH_MAX]; >> - size_t len = strlen(buf); >> + ssize_t len = strlen(buf); >> >> snprintf(path, sizeof(path), "%s/%s", cgroup, control); >> > > Looks good to me! > > Thanks! > Thanks. Is it now in linux-kselftest next. I will send this up next week for second update for 4.18-rc1 -- Shuah