From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 05 May 2017 21:03:23 +0000 Subject: [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field() Message-Id: <392fd14c-1a61-c3de-e5a7-14caaa51be75@users.sourceforge.net> List-Id: References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Ingo Molnar , Steven Rostedt Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 20:00:11 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code place. Signed-off-by: Markus Elfring --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index df566e21344d..36412deac24c 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1324,7 +1324,7 @@ static bool compatible_field(struct ftrace_event_field *field, { if (field = test_field) return true; - if (field = NULL || test_field = NULL) + if (!field || !test_field) return false; if (strcmp(field->name, test_field->name) != 0) return false; -- 2.12.2