From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()
Date: Sun, 19 Nov 2017 06:37:37 +0000 [thread overview]
Message-ID: <3a2f0905-231d-b2af-d1e8-1635158c6e53@users.sourceforge.net> (raw)
In-Reply-To: <s5hpobnscx1.wl-tiwai@suse.de>
>> @@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,
>>
>> *r_via = chip;
>> return 0;
>> +
>> +disable_device:
>> + pci_disable_device(pci);
>> + goto exit;
>> +free_chip:
>> + snd_via82xx_free(chip);
>> +exit:
>> + return err;
>
> Doubly goto doesn't look like an improvement.
Would you like to integrate another software update with the statement
“return err;” instead of “goto exit;” at this place?
Regards,
Markus
next prev parent reply other threads:[~2017-11-19 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:43 [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create() SF Markus Elfring
2017-08-22 17:57 ` Takashi Iwai
2017-11-19 6:37 ` SF Markus Elfring [this message]
2017-08-22 19:07 ` Dan Carpenter
2017-08-22 20:05 ` SF Markus Elfring
2017-08-22 20:16 ` Dan Carpenter
2017-08-22 20:19 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a2f0905-231d-b2af-d1e8-1635158c6e53@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox