From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Cc: kernel-janitors@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/44x: mask and shift to zero bug
Date: Thu, 31 Aug 2017 11:36:21 +0000 [thread overview]
Message-ID: <3xjgLY3B4Qz9t2y@ozlabs.org> (raw)
In-Reply-To: <20170825103340.op3uphrv3eyeutiz@mwanda>
On Fri, 2017-08-25 at 10:33:40 UTC, Dan Carpenter wrote:
> My static checker complains that 0x00001800 >> 13 is zero. Looking at
> the context, it seems like a copy and paste bug from the line below and
> probably 0x3 << 13 or 0x00006000 was intended.
>
> Fixes: 2af59f7d5c3e ("[POWERPC] 4xx: Add 405GPr and 405EP support in boot wrapper")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8d046759f6ad75824fdf7b9c9a3da0
cheers
prev parent reply other threads:[~2017-08-31 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 10:33 [PATCH] powerpc/44x: mask and shift to zero bug Dan Carpenter
2017-08-27 4:56 ` Benjamin Herrenschmidt
2017-08-28 7:57 ` Dan Carpenter
2017-08-28 8:36 ` Dan Carpenter
2017-08-28 11:19 ` Michael Ellerman
2017-08-31 11:36 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3xjgLY3B4Qz9t2y@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthias.fuchs@esd-electronics.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox