From: Michael Veeck <michael.veeck@gmx.net>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH] drivers/char/esp.c MIN/MAX removal
Date: Sat, 03 Jul 2004 15:05:23 +0000 [thread overview]
Message-ID: <40E819CC.5010206@gmx.net> (raw)
In-Reply-To: <40E819B9.60604@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
Patch (against 2.6.7) removes unnecessary min/max macros and changes
calls to use kernel.h macros instead.
Feedback is always welcome
Michael
[-- Attachment #2: patch-char-esp --]
[-- Type: text/plain, Size: 1164 bytes --]
--- linux-2.6.7-old/drivers/char/esp.c 2004-07-04 11:04:13.000000000 +0200
+++ linux-2.6.7-new/drivers/char/esp.c 2004-07-04 15:03:22.346728056 +0200
@@ -19,7 +19,7 @@
*
* rs_set_termios fixed to look also for changes of the input
* flags INPCK, BRKINT, PARMRK, IGNPAR and IGNBRK.
- * Bernd Anh���upl 05/17/96.
+ * Bernd Anh���������pl 05/17/96.
*
* --- End of notices from serial.c ---
*
@@ -140,7 +140,7 @@
static void change_speed(struct esp_struct *info);
static void rs_wait_until_sent(struct tty_struct *, int);
-
+
/*
* The ESP card has a clock rate of 14.7456 MHz (that is, 2**ESPC_SCALE
* times the normal 1.8432 Mhz clock of most serial boards).
@@ -150,10 +150,6 @@
/* Standard COM flags (except for COM4, because of the 8514 problem) */
#define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST)
-#ifndef MIN
-#define MIN(a,b) ((a) < (b) ? (a) : (b))
-#endif
-
/*
* tmp_buf is used as a temporary buffer by serial_write. We need to
* lock it in case the memcpy_fromfs blocks while swapping in a page,
[-- Attachment #3: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-07-03 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-03 15:05 [Kernel-janitors] [PATCH] drivers/char/epca.c MIN/MAX removal Michael Veeck
2004-07-03 15:05 ` Michael Veeck [this message]
2004-07-25 12:26 ` [Kernel-janitors] [PATCH] drivers/char/esp.c " maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E819CC.5010206@gmx.net \
--to=michael.veeck@gmx.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).