Re: [patch] net: moxa: fix an error code

Dan Carpenter
2016-03-02T11:21:29Z

On Wed, Mar 02, 2016 at 11:52:29AM +0100, Arnd Bergmann wrote:
> Did you find more of these?
>
> it doesn't matter much either way, but if you do multiple such patches,

One or two. I already sent the fixes. I think it was applied.

> I'd suggest using a single PTR_ERR_OR_ZERO() instead of IS_ERR()+PTR_ERR().
>
> I have found a couple of drivers in which that leads to better object
> code, and avoids a warning about a possibly uninitialized variable
> when the function gets inlined into another one (which won't happen
> for this driver).

Huh? I sent one where I could have done that but I deliberately didn't
because I wanted the uninitialized warning if I made a mistake. It
sounds like you're working around a GCC bug...

regards,
dan carpenter