From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-snps-arc@lists.infradead.org
Subject: Re: ARC-setup: Use seq_putc() in show_cpuinfo()
Date: Mon, 17 Oct 2016 17:39:41 +0000 [thread overview]
Message-ID: <418ba237-d501-c8d1-cf2b-3ec4b6d46785@users.sourceforge.net> (raw)
In-Reply-To: <10542905-ebe1-49f5-190b-3783137e7854@synopsys.com>
>>> Perhaps reword the changelog to say that seqc_putc is more efficient than
>>> seqc_printf to output a single char.
>>> I mean _printf is not wrong but not as efficient ?
>> I came along source files for a few other software modules with similar
>> change possibilities.
>> Unfortunately, the corresponding developers are not convinced yet
>> to replace a call of the function "seq_printf" at the end by
>> a "seq_putc" because of software efficiency reasons.
>
> I was ambivalent so far - but not anymore :-)
Interesting …
> what is the objection - can you point me to a few links where people don't think
> this is not a good idea.
Yes, of course. - Does the double negation in this wording indicate another
special software development concern?
How do you think about another update suggestion like "[PATCH] MD-RAID: Use seq_putc()
in three status functions" (from 2016-10-16)?
https://patchwork.kernel.org/patch/9378055/
https://lkml.kernel.org/r/<77fb6fdc-7480-8607-0af1-42f73c125b9d@users.sourceforge.net>
>> Do you find this update suggestion acceptable to some degree
>> for the function "setup"?
I am curious what your opinions will be for further development of the
function "show_cpuinfo" in the source file "arch/arc/kernel/setup.c".
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-10-17 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 19:56 [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring
2016-10-17 16:25 ` Vineet Gupta
2016-10-17 17:19 ` SF Markus Elfring
2016-10-17 17:23 ` Vineet Gupta
2016-10-17 17:39 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418ba237-d501-c8d1-cf2b-3ec4b6d46785@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox