From: "Stephen Biggs" <yrgrknmxpzlk@gawab.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH][RESUBMIT][12/21] drivers/scsi/aic7xxx/* - compile
Date: Mon, 14 Feb 2005 22:02:53 +0000 [thread overview]
Message-ID: <42113C2D.23785.52BFB7@localhost> (raw)
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 1530 bytes --]
Description: compile warning cleanup - handle error return from
scsi_add_host
Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic79xx_osm.c linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic79xx_osm.c
--- linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic79xx_osm.c 2005-02-12 12:06:25.000000000 +0200
+++ linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic79xx_osm.c 2005-02-12 17:35:49.000000000 +0200
@@ -2065,7 +2065,8 @@ ahd_linux_register_host(struct ahd_softc
ahd_unlock(ahd, &s);
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0)
- scsi_add_host(host, &ahd->dev_softc->dev); /* XXX handle failure */
+ if (scsi_add_host(host, &ahd->dev_softc->dev))
+ return (EIO);
scsi_scan_host(host);
#endif
return (0);
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic7xxx_osm.c linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic7xxx_osm.c
--- linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-02-12 12:06:25.000000000 +0200
+++ linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-02-12 17:35:49.000000000 +0200
@@ -1729,7 +1729,8 @@ ahc_linux_register_host(struct ahc_softc
ahc_unlock(ahc, &s);
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0)
- scsi_add_host(host, (ahc->dev_softc ? &ahc->dev_softc->dev : NULL)); /* XXX handle failure */
+ if (scsi_add_host(host, (ahc->dev_softc ? &ahc->dev_softc->dev : NULL)))
+ return (EIO);
scsi_scan_host(host);
#endif
return (0);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-02-14 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42113C2D.23785.52BFB7@localhost \
--to=yrgrknmxpzlk@gawab.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).