kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] 2.6.11-kj
Date: Thu, 03 Mar 2005 17:55:02 +0000	[thread overview]
Message-ID: <42274F76.7050707@osdl.org> (raw)
In-Reply-To: <20050302095710.GA3745@nd47.coderock.org>

Nishanth Aravamudan wrote:
> On Thu, Mar 03, 2005 at 06:41:19PM +0200, Alexey Dobriyan wrote:
> 
>>On Wednesday 02 March 2005 11:57, Domen Puncer wrote:
>>
>>
>>>remove_old_strings-drivers_telephony_ixj.patch
>>>  From: "Stephen Biggs" <yrgrknmxpzlk@gawab.com>
>>>  Subject: [KJ] [PATCH]  ixj* - compile warning cleanup
>>
>>drivers/telephony/ixj.c:6172:11: warning: incorrect type in argument 1 (different address spaces)
>>drivers/telephony/ixj.c:6172:11:    expected char *buf
>>drivers/telephony/ixj.c:6172:11:    got void [noderef] *argp<asn:1>
>>
>>-               if (copy_to_user(argp, ixj_c_revision, strlen(ixj_c_revision)))
>>-                       retval = -EFAULT;
>>+               sprintf(argp, "\nDriver version %i.%i.%i", IXJ_VER_MAJOR, IXJ_VER_MINOR, IXJ_BLD_VER);
>>
>>
>>>int_sleep_on-drivers_cdrom_mcdx.patch
>>>  From: Nishanth Aravamudan <nacc@us.ibm.com>
>>>  Subject: [KJ] [PATCH 16/20] cdrom/mcdx: remove 	interruptible_sleep_on_timeout() usage
>>
>>drivers/cdrom/mcdx.c:844:2: warning: mixing declarations and code
>>drivers/cdrom/mcdx.c: In function `mcdx_delay':
>>drivers/cdrom/mcdx.c:844: warning: ISO C90 forbids mixed declarations and code
> 
> 
> I do not see these compile-time warnings. Admittedly, that warning is
> also rather difficult to justify in the kernel, as code with local
> variables declared in the middle of functions is relatively common :)

but not allowed/desirable in linux kernel...

Probably Alexey is using an older but still supported/allowed gcc
(like 2.9x) and you (Nish) are using 3.4.x or 4.x, where mixed decls
and code are allowed.

> It could just be that I need to modify my gcc flags, though... In any
> case, I'm not sure how big of a problem this is, but of course am
> willing to fix it, if so desired.

It's a problem and should be fixed.

-- 
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-03-03 17:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02  9:57 [KJ] 2.6.11-kj Domen Puncer
2005-03-02 18:49 ` Nishanth Aravamudan
2005-03-03 15:44 ` Alexey Dobriyan
2005-03-03 17:43 ` Nishanth Aravamudan
2005-03-03 17:55 ` Randy.Dunlap [this message]
2005-03-03 18:18 ` Alexey Dobriyan
2005-03-03 18:34 ` Nishanth Aravamudan
2005-03-03 18:36 ` Nishanth Aravamudan
2005-03-03 20:34 ` Adrian Bunk
2005-03-03 20:39 ` Nishanth Aravamudan
2005-03-03 23:31 ` Alexey Dobriyan
2005-03-03 23:43 ` Alexey Dobriyan
2005-03-04  0:24 ` Nishanth Aravamudan
2005-03-04  0:25 ` [KJ] [UPDATE PATCH] cdrom/mcdx: fix wait-queue compile-time breakage Nishanth Aravamudan
2005-03-04 10:10 ` [KJ] 2.6.11-kj Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42274F76.7050707@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).