From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Colin Ian King <colin.i.king@gmail.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
linux-security-module@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] security: remove redundant assignment to variable rc
Date: Tue, 12 Nov 2024 17:00:22 +0300 [thread overview]
Message-ID: <433bb625-480f-46f2-986a-604fda49c046@stanley.mountain> (raw)
In-Reply-To: <20241112133224.GA340871@mail.hallyn.com>
On Tue, Nov 12, 2024 at 07:32:24AM -0600, Serge E. Hallyn wrote:
> On Tue, Nov 12, 2024 at 12:45:32PM +0000, Colin Ian King wrote:
> > In the case where rc is equal to EOPNOTSUPP it is being reassigned a
> > new value of zero that is never read. The following continue statement
> > loops back to the next iteration of the lsm_for_each_hook loop and
> > rc is being re-assigned a new value from the call to getselfattr.
> > The assignment is redundant and can be removed.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Reviewed-by: Serge Hallyn <serge@hallyn.com>
>
> (long as it doesn't go to stable :)
>
There is a tag for fixes which would break stable.
Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
But this isn't a fix and it wouldn't break stable so probably that's not
appropriate.
regards,
dan carpenter
next prev parent reply other threads:[~2024-11-12 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 12:45 [PATCH][next] security: remove redundant assignment to variable rc Colin Ian King
2024-11-12 13:32 ` Serge E. Hallyn
2024-11-12 14:00 ` Dan Carpenter [this message]
2025-01-05 2:54 ` Paul Moore
2025-01-05 2:52 ` [PATCH] " Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433bb625-480f-46f2-986a-604fda49c046@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=colin.i.king@gmail.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox