Re: [patch] PM / Hibernate: NULL dereferences on error paths

Dan Carpenter
2011-10-08T10:49:14Z

On Sat, Oct 08, 2011 at 09:28:48PM +1100, Bojan Smojver wrote:
> +out_clean:
> + if (data) {
> + for (thr = 0; thr < nr_threads; thr++) {
> + if (data[thr].thr)
> + kthread_stop(data[thr].thr);
> + }
> + vfree(data);
> + }
> + if (page) free_page((unsigned long)page);
>

This obviously works, but why don't you use a normal kernel unwind
style? You tried this complicated error handling before and it
already caused bugs... It's simpler if the error handling code has
no if statements.

regards,
dan carpenter