* [KJ] [PATCH] Fix arch/powerpc/platforms/iseries/pci.c to use
@ 2006-11-02 19:46 David KOENIG
2006-11-16 7:45 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: David KOENIG @ 2006-11-02 19:46 UTC (permalink / raw)
To: kernel-janitors
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
- From 605b32f23d62d93b0dcf36d4a8f8c2abf7b264be Mon Sep 17 00:00:00 2001
From: David KOENIG <david@patrick.teapy>
Date: Mon, 23 Oct 2006 11:58:27 -0700
Subject: [PATCH] Fix arch/powerpc/platforms/iseries/pci.c to use time_after
- ---
arch/powerpc/platforms/iseries/pci.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/iseries/pci.c
b/arch/powerpc/platforms/iseries/pci.c
index 4aa165e..b17fd12 100644
- --- a/arch/powerpc/platforms/iseries/pci.c
+++ b/arch/powerpc/platforms/iseries/pci.c
@@ -19,6 +19,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
+#include <linux/jiffies.h>
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/string.h>
@@ -457,7 +458,7 @@ static u8 iSeries_Read_Byte(const volati
static unsigned long last_jiffies;
static int num_printed;
- - if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
@@ -485,7 +486,7 @@ static u16 iSeries_Read_Word(const volat
static unsigned long last_jiffies;
static int num_printed;
- - if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
@@ -514,7 +515,7 @@ static u32 iSeries_Read_Long(const volat
static unsigned long last_jiffies;
static int num_printed;
- - if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
@@ -550,7 +551,7 @@ static void iSeries_Write_Byte(u8 data,
static unsigned long last_jiffies;
static int num_printed;
- - if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
@@ -576,7 +577,7 @@ static void iSeries_Write_Word(u16 data,
static unsigned long last_jiffies;
static int num_printed;
- - if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
@@ -602,7 +603,7 @@ static void iSeries_Write_Long(u32 data,
static unsigned long last_jiffies;
static int num_printed;
- - if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
- --
1.4.2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFSksCmhCgVPlWJY8RAo7TAKDAZOJuJXacUzgWJrCxJRUYGZDvEgCeIAOT
m0aaGonSn+wKbZ+5xIPNkfE=M2AF
-----END PGP SIGNATURE-----
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [KJ] [PATCH] Fix arch/powerpc/platforms/iseries/pci.c to use
2006-11-02 19:46 [KJ] [PATCH] Fix arch/powerpc/platforms/iseries/pci.c to use David KOENIG
@ 2006-11-16 7:45 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2006-11-16 7:45 UTC (permalink / raw)
To: kernel-janitors
On Thu, 02 Nov 2006 11:46:11 -0800 David KOENIG wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> - From 605b32f23d62d93b0dcf36d4a8f8c2abf7b264be Mon Sep 17 00:00:00 2001
> From: David KOENIG <david@patrick.teapy>
Is that a real email address?
> Date: Mon, 23 Oct 2006 11:58:27 -0700
> Subject: [PATCH] Fix arch/powerpc/platforms/iseries/pci.c to use time_after
Please use expected patch format as documented in
Documentation/SubmittingPatches.
Attempting to apply this patch give me:
6 out of 7 hunks FAILED -- saving rejects to file arch/powerpc/platforms/iseries/pci.c.rej
I suppose it's due to lots of extra hyphens (dashes) at the
beginning of the deleted lines. Does git do that?
or did the SHA1 envelope cause that? or gmail do it?
Either way, it's broken.
Oh, something also converted all of the tabs to spaces.
gmail may have done that for (to) you unless you used the
gmail SMTP interface (instead of the web interface).
> - ---
> arch/powerpc/platforms/iseries/pci.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/platforms/iseries/pci.c
> b/arch/powerpc/platforms/iseries/pci.c
> index 4aa165e..b17fd12 100644
> - --- a/arch/powerpc/platforms/iseries/pci.c
> +++ b/arch/powerpc/platforms/iseries/pci.c
> @@ -19,6 +19,7 @@
> * along with this program; if not, write to the Free Software
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
> +#include <linux/jiffies.h>
> #include <linux/kernel.h>
> #include <linux/list.h>
> #include <linux/string.h>
> @@ -457,7 +458,7 @@ static u8 iSeries_Read_Byte(const volati
> static unsigned long last_jiffies;
> static int num_printed;
>
> - - if ((jiffies - last_jiffies) > 60 * HZ) {
> + if (time_after(jiffies, last_jiffies + 60 * HZ)) {
> last_jiffies = jiffies;
> num_printed = 0;
> }
> @@ -485,7 +486,7 @@ static u16 iSeries_Read_Word(const volat
> static unsigned long last_jiffies;
> static int num_printed;
>
> - - if ((jiffies - last_jiffies) > 60 * HZ) {
> + if (time_after(jiffies, last_jiffies + 60 * HZ)) {
> last_jiffies = jiffies;
> num_printed = 0;
> }
> @@ -514,7 +515,7 @@ static u32 iSeries_Read_Long(const volat
> static unsigned long last_jiffies;
> static int num_printed;
>
> - - if ((jiffies - last_jiffies) > 60 * HZ) {
> + if (time_after(jiffies, last_jiffies + 60 * HZ)) {
> last_jiffies = jiffies;
> num_printed = 0;
> }
> @@ -550,7 +551,7 @@ static void iSeries_Write_Byte(u8 data,
> static unsigned long last_jiffies;
> static int num_printed;
>
> - - if ((jiffies - last_jiffies) > 60 * HZ) {
> + if (time_after(jiffies, last_jiffies + 60 * HZ)) {
> last_jiffies = jiffies;
> num_printed = 0;
> }
> @@ -576,7 +577,7 @@ static void iSeries_Write_Word(u16 data,
> static unsigned long last_jiffies;
> static int num_printed;
>
> - - if ((jiffies - last_jiffies) > 60 * HZ) {
> + if (time_after(jiffies, last_jiffies + 60 * HZ)) {
> last_jiffies = jiffies;
> num_printed = 0;
> }
> @@ -602,7 +603,7 @@ static void iSeries_Write_Long(u32 data,
> static unsigned long last_jiffies;
> static int num_printed;
>
> - - if ((jiffies - last_jiffies) > 60 * HZ) {
> + if (time_after(jiffies, last_jiffies + 60 * HZ)) {
> last_jiffies = jiffies;
> num_printed = 0;
> }
> - --
---
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-16 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-02 19:46 [KJ] [PATCH] Fix arch/powerpc/platforms/iseries/pci.c to use David KOENIG
2006-11-16 7:45 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).