From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 23 Sep 2016 12:17:43 +0000 Subject: Re: GPU-DRM-TILCDC: Less function calls in tilcdc_convert_slave_node() after error detection Message-Id: <48278d51-67b6-2c95-71e4-e922072ad9e9@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <2f3f7ad7-16a0-1dfb-d073-0d993cd767ee@users.sourceforge.net> <0be7fee0-64f7-fa02-0337-51376677343e@users.sourceforge.net> <3b791118-2977-f607-b816-dd5e833cfc75@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rob Clark Cc: kernel-janitors@vger.kernel.org, LKML , "dri-devel@lists.freedesktop.org" , Julia Lawall , Tomi Valkeinen , Jyri Sarha >> I see a need to improve not only correctness there but also a bit of >> software efficiency. > > If you can measure any performance difference and present some results > (esp. considering that this is something that just happens when the > driver is loaded), then we'll talk. Are you really interested to increase your software development attention for a quicker exception handling implementation in this function? > Until then, please don't send this sort of patch. Thank you. Will benchmark statistics change such a change rejection ever? Regards, Markus