public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Zhengwang Ruan <ruan.zhengwang@gmail.com>,
	fweisbec@gmail.com, mingo@redhat.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Trace: initialize variable to clear warning
Date: Wed, 29 Feb 2012 22:40:30 +0000	[thread overview]
Message-ID: <48875.1330555230@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 28 Feb 2012 09:16:31 EST." <1330438591.25686.214.camel@gandalf.stny.rr.com>

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Tue, 28 Feb 2012 09:16:31 EST, Steven Rostedt said:

> This is a bug in gcc that's fixed in 4.6 and beyond. I don't want to
> remove this warning because it will hide a real bug if page2 really does
> become uninitialized. If 4.6 gives a warning here, then I'll fix it.

> > -	void *page2;
> > +	void *uninitialized_var(page2);

How would you feel about this?

-	void *page2;
+	void *page2; /* gcc 4.5 bug causes incorrect "uninitialized" warning */

or something similar?


[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]

  reply	other threads:[~2012-02-29 22:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28  9:09 [PATCH] Trace: initialize variable to clear warning Zhengwang Ruan
2012-02-28 10:27 ` Borislav Petkov
2012-02-28 14:16 ` Steven Rostedt
2012-02-29 22:40   ` Valdis.Kletnieks [this message]
2012-03-01  1:09     ` Steven Rostedt
2012-03-01  2:08       ` Zhengwang Ruan
2012-03-01  2:23         ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48875.1330555230@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=fweisbec@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=ruan.zhengwang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox