Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()

Takashi Iwai
2017-08-22T12:28:12Z

On Tue, 22 Aug 2017 14:16:25 +0200,
Dan Carpenter wrote:
>
> err = snd_card_register(card);
> > - if (err < 0) {
> > + if (err) {
> > +free_card:
> > snd_card_free(card);
> > return err;
> > }
>
> I thought we agreed, yesterday, to never use this style of error
> handling?

Yeah, this is definitely no-go.

Also, please don't omit the negative value check.

thanks,

Takashi