Re: [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time

[walter harms <wharms@bfs.de>]

Robert P. J. Day schrieb:
> The "ramdisk" parameter was removed from the defunct rd.c file quite
> some time ago, in favour of the more specific "ramdisk_size"
> parameter so, for consistency, the same should be done here.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   the earlier removal was in fac8b209b1084bc85748bd54e13d00c1262b220f.
> 
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 5f7e64b..4bf8705 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str)
>  	rd_size = simple_strtol(str, NULL, 0);
>  	return 1;
>  }
> -static int __init ramdisk_size2(char *str)
> -{
> -	return ramdisk_size(str);
> -}
> -__setup("ramdisk=", ramdisk_size);
> -__setup("ramdisk_size=", ramdisk_size2);
> +__setup("ramdisk_size=", ramdisk_size);
>  #endif
> 
>  /*
> 


i do not use this parameter but people will be confused if it suddenly vanish.
IMHO it would be better to add something like

printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";

pleae note there is a clear kernel number what will put pressure on everyone
really to remove the parameter.

just my two cents,
 wh