* Re: [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time
2009-05-06 22:23 [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time Robert P. J. Day
@ 2009-05-07 7:16 ` walter harms
2009-05-07 8:56 ` Robert P. J. Day
2009-05-12 5:09 ` [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time param Nick Piggin
2 siblings, 0 replies; 4+ messages in thread
From: walter harms @ 2009-05-07 7:16 UTC (permalink / raw)
To: kernel-janitors
Robert P. J. Day schrieb:
> The "ramdisk" parameter was removed from the defunct rd.c file quite
> some time ago, in favour of the more specific "ramdisk_size"
> parameter so, for consistency, the same should be done here.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> the earlier removal was in fac8b209b1084bc85748bd54e13d00c1262b220f.
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 5f7e64b..4bf8705 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str)
> rd_size = simple_strtol(str, NULL, 0);
> return 1;
> }
> -static int __init ramdisk_size2(char *str)
> -{
> - return ramdisk_size(str);
> -}
> -__setup("ramdisk=", ramdisk_size);
> -__setup("ramdisk_size=", ramdisk_size2);
> +__setup("ramdisk_size=", ramdisk_size);
> #endif
>
> /*
>
i do not use this parameter but people will be confused if it suddenly vanish.
IMHO it would be better to add something like
printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
pleae note there is a clear kernel number what will put pressure on everyone
really to remove the parameter.
just my two cents,
wh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time
2009-05-06 22:23 [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time Robert P. J. Day
2009-05-07 7:16 ` walter harms
@ 2009-05-07 8:56 ` Robert P. J. Day
2009-05-12 5:09 ` [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time param Nick Piggin
2 siblings, 0 replies; 4+ messages in thread
From: Robert P. J. Day @ 2009-05-07 8:56 UTC (permalink / raw)
To: kernel-janitors
On Thu, 7 May 2009, walter harms wrote:
> Robert P. J. Day schrieb:
> > The "ramdisk" parameter was removed from the defunct rd.c file quite
> > some time ago, in favour of the more specific "ramdisk_size"
> > parameter so, for consistency, the same should be done here.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > the earlier removal was in fac8b209b1084bc85748bd54e13d00c1262b220f.
> >
> > diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> > index 5f7e64b..4bf8705 100644
> > --- a/drivers/block/brd.c
> > +++ b/drivers/block/brd.c
> > @@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str)
> > rd_size = simple_strtol(str, NULL, 0);
> > return 1;
> > }
> > -static int __init ramdisk_size2(char *str)
> > -{
> > - return ramdisk_size(str);
> > -}
> > -__setup("ramdisk=", ramdisk_size);
> > -__setup("ramdisk_size=", ramdisk_size2);
> > +__setup("ramdisk_size=", ramdisk_size);
> > #endif
> >
> > /*
> >
>
>
> i do not use this parameter but people will be confused if it suddenly vanish.
> IMHO it would be better to add something like
>
> printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
>
> pleae note there is a clear kernel number what will put pressure on everyone
> really to remove the parameter.
>
> just my two cents,
> wh
that deprecated parameter was removed entirely in an earlier patch i
submitted (see above), and everyone signed off on it. so it seems
unlikely to cause major problems to remove it a second time after it
was re-introduced, but i'll leave that decision to others.
rday
--
====================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
====================================
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time param.
2009-05-06 22:23 [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time Robert P. J. Day
2009-05-07 7:16 ` walter harms
2009-05-07 8:56 ` Robert P. J. Day
@ 2009-05-12 5:09 ` Nick Piggin
2 siblings, 0 replies; 4+ messages in thread
From: Nick Piggin @ 2009-05-12 5:09 UTC (permalink / raw)
To: kernel-janitors
On Thu, May 07, 2009 at 04:56:21AM -0400, Robert P. J. Day wrote:
> On Thu, 7 May 2009, walter harms wrote:
>
> > Robert P. J. Day schrieb:
> > > The "ramdisk" parameter was removed from the defunct rd.c file quite
> > > some time ago, in favour of the more specific "ramdisk_size"
> > > parameter so, for consistency, the same should be done here.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > >
> > > ---
> > >
> > > the earlier removal was in fac8b209b1084bc85748bd54e13d00c1262b220f.
> > >
> > > diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> > > index 5f7e64b..4bf8705 100644
> > > --- a/drivers/block/brd.c
> > > +++ b/drivers/block/brd.c
> > > @@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str)
> > > rd_size = simple_strtol(str, NULL, 0);
> > > return 1;
> > > }
> > > -static int __init ramdisk_size2(char *str)
> > > -{
> > > - return ramdisk_size(str);
> > > -}
> > > -__setup("ramdisk=", ramdisk_size);
> > > -__setup("ramdisk_size=", ramdisk_size2);
> > > +__setup("ramdisk_size=", ramdisk_size);
> > > #endif
> > >
> > > /*
> > >
> >
> >
> > i do not use this parameter but people will be confused if it suddenly vanish.
> > IMHO it would be better to add something like
> >
> > printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
> >
> > pleae note there is a clear kernel number what will put pressure on everyone
> > really to remove the parameter.
> >
> > just my two cents,
> > wh
>
> that deprecated parameter was removed entirely in an earlier patch i
> submitted (see above), and everyone signed off on it. so it seems
> unlikely to cause major problems to remove it a second time after it
> was re-introduced, but i'll leave that decision to others.
OK, the commit to remove that must have gone in concurently to my
rewrite, because I just copied those parameters.
It probably takes all of a couple of bytes, of init text at that.
But since you'd already got that patch in to remove it completely,
and fixed up the documentation...
Acked-by: Nick Piggin <npiggin@suse.de>
Do you care to send it to Linus?
^ permalink raw reply [flat|nested] 4+ messages in thread