Re: [PATCH] char/vme_scc: adding __init macro to vme_scc.c

Matheos Worku
2009-08-20T20:51:50Z

Peter Huewe wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
>
> Trivial patch which adds the __init macro to the module_init
> function and all of its helper functions of char/vme_scc.c
>
> Alan or Geert, please have a look at the small patch and either pull it through
> your tree, or please ack' it so Jiri can pull it through the trivial tree.
>
> linux version 2.6.31-rc6 - linus git tree, Do 20. Aug 22:26:06 CEST 2009
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> diff --git a/drivers/char/vme_scc.c b/drivers/char/vme_scc.c
> index 994e1a5..8b24729 100644
> --- a/drivers/char/vme_scc.c
> +++ b/drivers/char/vme_scc.c
> @@ -136,7 +136,7 @@ static const struct tty_port_operations scc_port_ops = {
> * vme_scc_init() and support functions
> *---------------------------------------------------------------------------*/
>
> -static int scc_init_drivers(void)
> +static int __init scc_init_drivers(void)
> {
> int error;
>
> @@ -172,7 +172,7 @@ static int scc_init_drivers(void)
> /* ports[] array is indexed by line no (i.e. [0] for ttyS0, [1] for ttyS1).
> */
>
> -static void scc_init_portstructs(void)
> +static void __init scc_init_portstructs(void)
> {
> struct scc_port *port;
> int i;
> @@ -195,7 +195,7 @@ static void scc_init_portstructs(void)
>
>
> #ifdef CONFIG_MVME147_SCC
> -static int mvme147_scc_init(void)
> +static int __init mvme147_scc_init(void)
> {
> struct scc_port *port;
> int error;
> @@ -298,7 +298,7 @@ fail:
>
>
> #ifdef CONFIG_MVME162_SCC
> -static int mvme162_scc_init(void)
> +static int __init mvme162_scc_init(void)
> {
> struct scc_port *port;
> int error;
> @@ -404,7 +404,7 @@ fail:
>
>
> #ifdef CONFIG_BVME6000_SCC
> -static int bvme6000_scc_init(void)
> +static int __init bvme6000_scc_init(void)
> {
> struct scc_port *port;
> int error;
> @@ -503,7 +503,7 @@ fail_free_b_rx:
> #endif
>
>
> -static int vme_scc_init(void)
> +static int __init vme_scc_init(void)
> {
> int res = -ENODEV;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Then there are issnvram.txt iss.conf etc ... I guess we need to change
these as well.
How about error messages? I assume they would have ISS in them.
Regards
Matheos