From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Date: Mon, 04 Jan 2010 14:23:23 +0000 Subject: Re: [PATCH 5/5] net/ipv4 : Correct the size argument to kzalloc Message-Id: <4B41F9DB.1010908@trash.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Julia Lawall wrote: > From: Julia Lawall > > obj has type struct snmp_object **, not struct snmp_object *. But indeed > it is not even clear why kmalloc is needed. The memory is freed by the end > of the function, so the local variable of pointer type should be sufficient. Thanks. As this is basically just an unneeded and oversized allocation without any bad consequences, I've applied it to nf-next-2.6.git.