* [PATCH 4/11] arch/x86/kvm: Correct NULL test
@ 2010-02-06 8:43 Julia Lawall
2010-02-07 11:47 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-02-06 8:43 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, kvm, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
msr was tested above, so the second test is not needed.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@
if (x = NULL || ...) {
... when forall
return ...; }
... when != goto l;
when != x = e
when != &x
*x = NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/x86/kvm/vmx.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 7375ae1..422bfc8 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -1609,8 +1609,6 @@ static void vmx_set_efer(struct kvm_vcpu *vcpu, u64 efer)
*/
vmx_load_host_state(to_vmx(vcpu));
vcpu->arch.shadow_efer = efer;
- if (!msr)
- return;
if (efer & EFER_LMA) {
vmcs_write32(VM_ENTRY_CONTROLS,
vmcs_read32(VM_ENTRY_CONTROLS) |
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/11] arch/x86/kvm: Correct NULL test
2010-02-06 8:43 [PATCH 4/11] arch/x86/kvm: Correct NULL test Julia Lawall
@ 2010-02-07 11:47 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-02-07 11:47 UTC (permalink / raw)
To: Julia Lawall
Cc: Marcelo Tosatti, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
x86, kvm, linux-kernel, kernel-janitors
On 02/06/2010 10:43 AM, Julia Lawall wrote:
> From: Julia Lawall<julia@diku.dk>
>
> msr was tested above, so the second test is not needed.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-07 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-06 8:43 [PATCH 4/11] arch/x86/kvm: Correct NULL test Julia Lawall
2010-02-07 11:47 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).