From: Hans de Goede <hdegoede@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] hwmon: saving negative errors in unsigned
Date: Thu, 11 Mar 2010 11:08:32 +0000 [thread overview]
Message-ID: <4B98CF30.70307@redhat.com> (raw)
In-Reply-To: <20100311103151.GN6321@bicker>
Ack.
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 03/11/2010 11:31 AM, Dan Carpenter wrote:
> "ret" is used to store the return value for watchdog_trigger() and it
> should be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
> index 9de81a4..612807d 100644
> --- a/drivers/hwmon/w83793.c
> +++ b/drivers/hwmon/w83793.c
> @@ -1294,7 +1294,7 @@ static int watchdog_close(struct inode *inode, struct file *filp)
> static ssize_t watchdog_write(struct file *filp, const char __user *buf,
> size_t count, loff_t *offset)
> {
> - size_t ret;
> + ssize_t ret;
> struct w83793_data *data = filp->private_data;
>
> if (count) {
next prev parent reply other threads:[~2010-03-11 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 10:31 [patch] hwmon: saving negative errors in unsigned Dan Carpenter
2010-03-11 11:08 ` Hans de Goede [this message]
2010-03-11 15:28 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B98CF30.70307@redhat.com \
--to=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox