From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Thu, 11 Mar 2010 11:08:32 +0000
Subject: Re: [patch] hwmon: saving negative errors in unsigned
Message-Id: <4B98CF30.70307@redhat.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20100311103151.GN6321@bicker>
In-Reply-To: <20100311103151.GN6321@bicker>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

Ack.

Acked-by: Hans de Goede <hdegoede@redhat.com>

On 03/11/2010 11:31 AM, Dan Carpenter wrote:
> "ret" is used to store the return value for watchdog_trigger() and it
> should be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
> index 9de81a4..612807d 100644
> --- a/drivers/hwmon/w83793.c
> +++ b/drivers/hwmon/w83793.c
> @@ -1294,7 +1294,7 @@ static int watchdog_close(struct inode *inode, struct file *filp)
>   static ssize_t watchdog_write(struct file *filp, const char __user *buf,
>   	size_t count, loff_t *offset)
>   {
> -	size_t ret;
> +	ssize_t ret;
>   	struct w83793_data *data = filp->private_data;
>
>   	if (count) {