From: Andi Kleen <ak@linux.intel.com>
To: Dan Carpenter <error27@gmail.com>,
David Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Hellstrom <thellstrom@vmware.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm: sysfs files error handling
Date: Sun, 28 Mar 2010 20:55:14 +0000 [thread overview]
Message-ID: <4BAFC232.8010404@linux.intel.com> (raw)
In-Reply-To: <20100328112438.GK5069@bicker>
, Dan Carpenter wrote:
>
> In the original code we used "j" as an iterator but we used "i" as an
> index.
>
> - for (j = 0; j< i; j++)
> - device_remove_file(&connector->kdev,
> -&connector_attrs[i]);
I guess this really should be a attribute group anyways?
Typically when there's such a open coded loop it means the wrong
interfaces are being used.
-Andi
next prev parent reply other threads:[~2010-03-28 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 11:24 [patch] drm: sysfs files error handling Dan Carpenter
2010-03-28 20:55 ` Andi Kleen [this message]
2010-03-30 14:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAFC232.8010404@linux.intel.com \
--to=ak@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox