From: Tao Ma <tao.ma@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: Re: [patch] ocfs2: potential ERR_PTR dereference on error paths
Date: Thu, 22 Apr 2010 13:44:10 +0000 [thread overview]
Message-ID: <4BD052AA.2090401@oracle.com> (raw)
In-Reply-To: <20100422093929.GK29647@bicker>
Dan Carpenter wrote:
> If "handle" is non null at the end of the function then we assume it's a
> valid pointer and pass it to ocfs2_commit_trans();
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index 07cc8bb..ae8e161 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -558,6 +558,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb,
> handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
> if (IS_ERR(handle)) {
> status = PTR_ERR(handle);
> + handle = NULL;
> mlog_errno(status);
> goto out;
> }
>
Good catch.
Acked-by: Tao Ma <tao.ma@oracle.com>
next prev parent reply other threads:[~2010-04-22 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:39 [patch] ocfs2: potential ERR_PTR dereference on error paths Dan Carpenter
2010-04-22 13:44 ` Tao Ma [this message]
2010-04-23 21:45 ` Joel Becker
2010-05-06 15:24 ` [Ocfs2-devel] " Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD052AA.2090401@oracle.com \
--to=tao.ma@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).