From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Date: Mon, 24 May 2010 20:12:19 +0000 Subject: Re: [patch] sctp: dubious bitfields in sctp_transport Message-Id: <4BFADDA3.2090307@hp.com> List-Id: References: <20100522202024.GL22515@bicker> In-Reply-To: <20100522202024.GL22515@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Sridhar Samudrala , "David S. Miller" , Wei Yongjun , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter wrote: > Sparse complains because these one-bit bitfields are signed. > include/net/sctp/structs.h:879:24: error: dubious one-bit signed bitfield > include/net/sctp/structs.h:889:31: error: dubious one-bit signed bitfield > include/net/sctp/structs.h:895:26: error: dubious one-bit signed bitfield > include/net/sctp/structs.h:898:31: error: dubious one-bit signed bitfield > include/net/sctp/structs.h:901:27: error: dubious one-bit signed bitfield > > It doesn't cause a problem in the current code, but it would be better > to clean it up. This was introduced by c0058a35aacc7: "sctp: Save some > room in the sctp_transport by using bitfields". > > Signed-off-by: Dan Carpenter > --- > It looks like this header is exported to user space. I don't know if > that makes a difference. That shouldn't make a difference. -vlad > > diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h > index 6173c61..4b86011 100644 > --- a/include/net/sctp/structs.h > +++ b/include/net/sctp/structs.h > @@ -876,7 +876,7 @@ struct sctp_transport { > > /* Reference counting. */ > atomic_t refcnt; > - int dead:1, > + __u32 dead:1, > /* RTO-Pending : A flag used to track if one of the DATA > * chunks sent to this address is currently being > * used to compute a RTT. If this flag is 0, >