Re: [PATCH 12/27] drivers/ieee1394: Use memdup_user

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Andrew Morton wrote:
> On Sat, 22 May 2010 11:25:47 +0200
> Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> 
>> Julia Lawall wrote:
>>> Use memdup_user when user data is immediately copied into the
>>> allocated region.
>> Looks nice.  We won't apply janitorial updates to drivers/ieee1394
>> anymore though, since it is made obsolete by drivers/firewire and to be
>> removed sooner than later.  (I will post a proposed removal schedule
>> today to make this better known.)
> 
> I don't see much point in declaring a moratorium against
> drivers/ieee1394.  Perhaps that removal will never happen.

That's a wrong impression due to us driver developers dragging the
coexistence of two driver stacks out for too long.

> Perhaps
> third parties will find reason to revert that removal and to continue
> to maintain drivers/ieee1394.  Perhaps people will take code snippets
> from drivers/ieee1394 and will move them into drivers/firewire.
> 
> The bottom line is that the patch improves the code.  And there ain't
> nothing wrong with having better code.

This code is as good as it needs to be.

Spending time on things that can be done is fun, but spending time on
things that need to be done can't hurt either.
-- 
Stefan Richter
-===-=-=- -=-= =-=-
http://arcgraph.de/sr/