public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Nicolas Palix <npalix@diku.dk>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	Roland Dreier <rdreier@cisco.com>, Joe Perches <joe@perches.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Sam Ravnborg <sam@ravnborg.org>, Julia Lawall <julia@diku.dk>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	cocci@diku.dk, Wolfram Sang <w.sang@pengutronix.de>,
	Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci
Date: Thu, 03 Jun 2010 09:51:43 +0000	[thread overview]
Message-ID: <4C077B2F.8010204@suse.cz> (raw)
In-Reply-To: <1273508667-5152-4-git-send-email-npalix@diku.dk>

On 10.5.2010 18:24, Nicolas Palix wrote:
> +@script:python depends on org@
> +p << r.p;
> +x << r.x;
> +@@
> +
> +msg="%s" % (x)
> +msg_safe=msg.replace("[","@(").replace("]",")")
> +coccilib.org.print_todo(p[0], msg_safe)
> +
> +@script:python depends on report@
> +p << r.p;
> +x << r.x;
> +@@
> +
> +msg="WARNING: kzalloc should be used for %s, instead of kmalloc/memset" % (x)
> +coccilib.report.print_report(p[0], msg_safe)

msg_safe is not defined in this scriptlet, I'm only getting

Traceback (most recent call last):
  File "<string>", line 5, in <module>
NameError: name 'msg_safe' is not defined

Michal

  reply	other threads:[~2010-06-03  9:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 16:19 [PATCH 0/4] Add a Coccinelle front-end script Nicolas Palix
2010-05-10 16:24 ` Nicolas Palix
2010-05-10 16:24   ` [PATCH 1/4] Add targets to use the Coccinelle checker Nicolas Palix
2010-05-12  6:42     ` Américo Wang
2010-05-28  7:04       ` Joerg Roedel
2010-06-03  9:50     ` Michal Marek
2010-06-03 10:23     ` Sam Ravnborg
2010-06-04  9:56       ` Nicolas Palix
2010-06-04 10:38         ` Sam Ravnborg
2010-05-10 16:24   ` [PATCH 2/4] Add scripts/coccinelle/drop_kmalloc_cast.cocci Nicolas Palix
2010-05-10 16:24   ` [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci Nicolas Palix
2010-06-03  9:51     ` Michal Marek [this message]
2010-06-03 10:11       ` Nicolas Palix
2010-05-10 16:24   ` [PATCH 4/4] Add scripts/coccinelle/resource_size.cocci Nicolas Palix
2010-05-10 16:52     ` Pekka Enberg
2010-05-27 11:48       ` Nicolas Palix
2010-05-11  2:14   ` [PATCH 0/4] Add a Coccinelle front-end script Andy Isaacson
2010-05-17  9:31     ` Wolfram Sang
2010-05-28  7:09   ` Joerg Roedel
2010-05-28  7:25     ` Wolfram Sang
2010-05-28  7:31       ` Julia Lawall
2010-05-28  7:39         ` walter harms
2010-05-28  9:15         ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2010-05-10 16:19 [PATCH 3/4] Add scripts/coccinelle/kzalloc-simple.cocci Nicolas Palix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C077B2F.8010204@suse.cz \
    --to=mmarek@suse.cz \
    --cc=Gilles.Muller@lip6.fr \
    --cc=akpm@linux-foundation.org \
    --cc=cocci@diku.dk \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npalix@diku.dk \
    --cc=rdreier@cisco.com \
    --cc=rdunlap@xenotime.net \
    --cc=sam@ravnborg.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox