From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Thu, 10 Jun 2010 09:22:49 +0000 Subject: Re: [patch] enic: cleanup vic_provinfo_alloc() Message-Id: <4C10AEE9.4090804@bfs.de> List-Id: References: <20100610075903.GL5483@bicker> In-Reply-To: <20100610075903.GL5483@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Scott Feldman , Vasanthy Kolluri , Roopa Prabhu , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter schrieb: > If oui were a null variable then vic_provinfo_alloc() would leak memory. > But this function is only called from one place and oui is not null so > I removed the check. > > I also moved the memory allocation down a line so it was easier to spot. > (No one ever reads variable declarations). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/enic/vnic_vic.c b/drivers/net/enic/vnic_vic.c > index d769772..0a35085 100644 > --- a/drivers/net/enic/vnic_vic.c > +++ b/drivers/net/enic/vnic_vic.c > @@ -25,9 +25,10 @@ > > struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, u8 *oui, u8 type) > { > - struct vic_provinfo *vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags); > + struct vic_provinfo *vp; > > - if (!vp || !oui) > + vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags); > + if (!vp) > return NULL; > > memcpy(vp->oui, oui, sizeof(vp->oui)); > -- This looks like memdup() ? re, wh