From: walter harms <wharms@bfs.de>
To: Dan Carpenter <error27@gmail.com>,
Kulikov Vasiliy <segooon@gmail.com>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/25] r852: remove casts from void*
Date: Tue, 29 Jun 2010 12:56:49 +0000 [thread overview]
Message-ID: <4C29ED91.2010309@bfs.de> (raw)
In-Reply-To: <20100629123850.GO19184@bicker>
Dan Carpenter schrieb:
> On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote:
>> Remove unnesessary casts from void*.
>>
>
> 1) The subjects are not helpful. This one should say something about
> "mtd" but it doesn't.
> 2) These haven't been run through checkpatch.pl. In fact, I can't be
> certain anyone looked at these patches when I see things like:
>
> - if((( lp = (struct wl_private *)dev->priv ) != NULL ) &&
> - !( lp->flags & WVLAN2_UIL_BUSY )) {
> + if((( lp = dev->priv ) != NULL ) &&
> + !( lp->flags & WVLAN2_UIL_BUSY )) {
>
> On the recieving end, someone has to review every patch that gets merged.
>
same problem in drivers/scsi/sg.c but that would requiere a additional patch.
re,
wh
next prev parent reply other threads:[~2010-06-29 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 10:14 [PATCH 01/25] r852: remove casts from void* Kulikov Vasiliy
2010-06-29 12:42 ` Dan Carpenter
2010-06-29 12:56 ` walter harms [this message]
2010-06-29 15:28 ` Kulikov Vasiliy
2010-06-29 19:01 ` Dan Carpenter
2010-07-13 9:57 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C29ED91.2010309@bfs.de \
--to=wharms@bfs.de \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).