From: Greg Ungerer <gerg@snapgear.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
John Kacur <jkacur@redhat.com>, Tejun Heo <tj@kernel.org>,
Maxim Kuvyrkov <maxim@codesourcery.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of
Date: Thu, 15 Jul 2010 06:52:58 +0000 [thread overview]
Message-ID: <4C3EB04A.90000@snapgear.com> (raw)
In-Reply-To: <20100715064354.GA5555@albatros>
Kulikov Vasiliy wrote:
> On Thu, Jul 15, 2010 at 10:29 +1000, Greg Ungerer wrote:
>> Hi Kulikov,
>>
>> Kulikov Vasiliy wrote:
>>> Use %p instead of %08x in printk().
>>>
>>> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>
>> Do you want me to push this to Linus via the m68knommu git tree?
> Yeah, it would be good.
OK, done.
Thanks
Greg
>> Regards
>> Greg
>>
>>
>>
>>> ---
>>> arch/m68knommu/kernel/process.c | 10 +++++-----
>>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
>>> index 6aa6613..1096c0e 100644
>>> --- a/arch/m68knommu/kernel/process.c
>>> +++ b/arch/m68knommu/kernel/process.c
>>> @@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
>>> fp->d0, fp->d1, fp->d2, fp->d3);
>>> printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
>>> fp->d4, fp->d5, fp->a0, fp->a1);
>>> - printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
>>> - (unsigned int) rdusp(), (unsigned int) fp);
>>> + printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
>>> + (unsigned int) rdusp(), fp);
>>> printk(KERN_EMERG "\nCODE:");
>>> tp = ((unsigned char *) fp->pc) - 0x20;
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
>>> if ((i % 0x10) = 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
>>> tp = ((unsigned char *) fp) - 0x40;
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
>>> if ((i % 0x10) = 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
>>> tp = (unsigned char *) (rdusp() - 0x10);
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
>>> if ((i % 0x10) = 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>
>> --
>> ------------------------------------------------------------------------
>> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
>> SnapGear Group, McAfee PHONE: +61 7 3435 2888
>> 8 Gardner Close FAX: +61 7 3217 5323
>> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2010-07-15 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 18:01 [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Kulikov Vasiliy
2010-07-15 0:29 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of Greg Ungerer
2010-07-15 6:43 ` Kulikov Vasiliy
2010-07-15 6:52 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3EB04A.90000@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=jkacur@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim@codesourcery.com \
--cc=segooon@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).