From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kprobes: add sparse context annotation
Date: Fri, 06 Aug 2010 08:48:51 +0000 [thread overview]
Message-ID: <4C5BCC73.30306@hitachi.com> (raw)
In-Reply-To: <1281082375-13356-1-git-send-email-namhyung@gmail.com>
Ananth N Mavinakayanahalli wrote:
> On Fri, Aug 06, 2010 at 05:12:55PM +0900, Namhyung Kim wrote:
>
>> void __kprobes kretprobe_hash_unlock(struct task_struct *tsk,
>> unsigned long *flags)
>> +__releases(hlisk_lock)
>
> You surely meant hlist_lock, didn't you?
>
>> {
>> unsigned long hash = hash_ptr(tsk, KPROBE_HASH_BITS);
>> spinlock_t *hlist_lock;
>> @@ -859,6 +862,7 @@ void __kprobes kretprobe_hash_unlock(struct task_struct *tsk,
>>
>> static void __kprobes kretprobe_table_unlock(unsigned long hash,
>> unsigned long *flags)
>> +__releases(hlisk_lock)
> ^^^^^^
>> {
>> spinlock_t *hlist_lock = kretprobe_table_lock_ptr(hash);
>> spin_unlock_irqrestore(hlist_lock, *flags);
>> --
>> 1.7.0.4
Oops, right...
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2010-08-06 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 8:12 [PATCH] kprobes: add sparse context annotation Namhyung Kim
2010-08-06 8:17 ` Namhyung Kim
2010-08-06 8:47 ` Masami Hiramatsu
2010-08-06 8:48 ` Masami Hiramatsu [this message]
2010-08-06 8:53 ` Ananth N Mavinakayanahalli
2010-09-02 4:15 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5BCC73.30306@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).