From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 16 Sep 2010 12:54:29 +0000 Subject: Re: [PATCH] md: do not use ++ in rcu_dereference() argument Message-Id: <4C921385.2080205@redhat.com> List-Id: References: <1283711539-7123-1-git-send-email-segooon@gmail.com> <20100905190139.GA3163@merkur.ravnborg.org> <20100905192335.GA8140@albatros> <20100905203908.GA3228@merkur.ravnborg.org> <20100906152931.1d4a1d07@notabene> In-Reply-To: <20100906152931.1d4a1d07@notabene> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Neil Brown Cc: Sam Ravnborg , Kulikov Vasiliy , kernel-janitors@vger.kernel.org, Jens Axboe , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org On 09/06/2010 08:29 AM, Neil Brown wrote: > I've taken the opportunity to substantially re-write that code. > > It's better to have two patches, one a backportable one liner that fixes the bug, the other, on top, that cleans up the code but has no sematic changes. This makes it substantially easier to review. When considering the first patch you see the change plainly. When reviewing the second patch you make sure no semantic changes were made at all. -- error compiling committee.c: too many arguments to function