From: Corey Minyard <minyard@acm.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipmi: make static checkers happy about range checks
Date: Sat, 18 Sep 2010 19:19:19 +0000 [thread overview]
Message-ID: <4C9510B7.6050903@acm.org> (raw)
In-Reply-To: <20100917190702.GA5384@bicker>
I'm ok with this, I don't think it will make any real difference besides
the compiler converting that comparison to unsigned. I wish I had made
that unsigned.
-corey
On 09/17/2010 02:26 PM, Dan Carpenter wrote:
> I'm working on a Smatch check that complains that addr->channel comes
> from the user and it might be negative. It actually can *not* be
> negative because we already checked that when we called
> ipmi_validate_addr() from handle_send_req(). Also it can't be greater
> than or equal to IPMI_MAX_CHANNELS because we already verified that as
> well.
>
> Although this change doesn't do anything, it's still a cleanup because
> it makes the checking consistent and also it silences the static
> analysis warnings.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
> ---
> Really, I would prefer to just make ->channel unsigned but the type
> comes from the IPMI spec.
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 4f3f8c9..57f4c80 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -1527,7 +1527,7 @@ static int i_ipmi_request(ipmi_user_t user,
> long seqid;
> int broadcast = 0;
>
> - if (addr->channel>= IPMI_MAX_CHANNELS) {
> + if (addr->channel< 0 || addr->channel>= IPMI_MAX_CHANNELS) {
> ipmi_inc_stat(intf, sent_invalid_commands);
> rv = -EINVAL;
> goto out_err;
> @@ -1657,7 +1657,7 @@ static int i_ipmi_request(ipmi_user_t user,
> unsigned char ipmb_seq;
> long seqid;
>
> - if (addr->channel>= IPMI_MAX_CHANNELS) {
> + if (addr->channel< 0 || addr->channel>= IPMI_MAX_CHANNELS) {
> ipmi_inc_stat(intf, sent_invalid_commands);
> rv = -EINVAL;
> goto out_err;
> @@ -1797,7 +1797,7 @@ static int check_addr(ipmi_smi_t intf,
> unsigned char *saddr,
> unsigned char *lun)
> {
> - if (addr->channel>= IPMI_MAX_CHANNELS)
> + if (addr->channel< 0 || addr->channel>= IPMI_MAX_CHANNELS)
> return -EINVAL;
> *lun = intf->channels[addr->channel].lun;
> *saddr = intf->channels[addr->channel].address;
>
prev parent reply other threads:[~2010-09-18 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 19:26 [patch] ipmi: make static checkers happy about range checks Dan Carpenter
2010-09-18 19:19 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9510B7.6050903@acm.org \
--to=minyard@acm.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox