From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Date: Wed, 22 Sep 2010 10:02:30 +0000 Subject: Re: [PATCH 04/14] memstick: core: fix device_register() error handling Message-Id: <4C99D436.700@panasas.com> List-Id: References: <1284900889-24369-1-git-send-email-segooon@gmail.com> <20100921152031.30365b3f.akpm@linux-foundation.org> <20100921224947.GA20183@kroah.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kay Sievers Cc: Greg KH , Andrew Morton , Vasiliy Kulikov , kernel-janitors@vger.kernel.org, Tejun Heo , Jiri Slaby , linux-kernel@vger.kernel.org, James Bottomley , Dan Carpenter On 09/22/2010 10:53 AM, Kay Sievers wrote: > On Wed, Sep 22, 2010 at 00:49, Greg KH wrote: > >> int device_register(struct device *dev) >> { >> + int retval; >> + >> device_initialize(dev); >> - return device_add(dev); >> + retval = device_add(dev); >> + if (retval) >> + put_device(dev); >> + return retval; >> } > >> Kay, what am I missing here, why can't we just do this? Hm, the >> side-affect might be that if device_register() fails, NO ONE had better >> touch that device again, as it might have just been freed from the >> system. I wonder if that will cause problems... > > That looks right, besides that there might be callers already doing > this. Which needs to be checked. > > I never liked this pretty useless "convenience API", which just wraps > two simple functions and the first one can never fail anyway. > > We better remove that device_register() stuff entirely in the long > run, it's not doing any good. At the kobject level we killed the same > stuff already long ago. > That would be fine, and ping me when you do it, I'll help with my driver. But don't forget to let us have a way to embed a device inside a bigger structure. For meanwhile Please check the patch James sent to add_device that cleans up the allocation of the kobj.name member. (And the comment made there) > Kay Thanks Boaz