From: Thomas Hellstrom <thellstrom@vmware.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Jerome Glisse <jglisse@redhat.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] gpu: drm: vmwgfx: fix information leak to userland
Date: Mon, 08 Nov 2010 15:40:59 +0000 [thread overview]
Message-ID: <4CD81A0B.30209@vmware.com> (raw)
In-Reply-To: <1289054477-18100-1-git-send-email-segooon@gmail.com>
On 11/06/2010 03:41 PM, Vasiliy Kulikov wrote:
> Structure drm_vmw_fence_rep is copied to userland with field "pad64"
> uninitialized. It leads to leaking of contents of kernel stack memory.
>
> Signed-off-by: Vasiliy Kulikov<segooon@gmail.com>
> ---
> Compile tested.
>
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 51d9f9f..76954e3 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -691,6 +691,7 @@ int vmw_execbuf_ioctl(struct drm_device *dev, void *data,
>
> fence_rep.error = ret;
> fence_rep.fence_seq = (uint64_t) sequence;
> + fence_rep.pad64 = 0;
>
> user_fence_rep = (struct drm_vmw_fence_rep __user *)
> (unsigned long)arg->fence_rep;
>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
prev parent reply other threads:[~2010-11-08 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 14:41 [PATCH] gpu: drm: vmwgfx: fix information leak to userland Vasiliy Kulikov
2010-11-08 15:40 ` Thomas Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD81A0B.30209@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=jglisse@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox