From: Lars-Peter Clausen <lars@metafoo.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] rtc: jz4740: signedness bug
Date: Sat, 13 Nov 2010 20:02:23 +0000 [thread overview]
Message-ID: <4CDEEECF.1070709@metafoo.de> (raw)
In-Reply-To: <20101113182626.GC1795@bicker>
Dan Carpenter wrote:
> platform_get_irq() can return negatives so the rtc->irq should be signed
> to handle it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-By: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> index 2e16f72..cfcd2da 100644
> --- a/drivers/rtc/rtc-jz4740.c
> +++ b/drivers/rtc/rtc-jz4740.c
> @@ -42,7 +42,7 @@ struct jz4740_rtc {
>
> struct rtc_device *rtc;
>
> - unsigned int irq;
> + int irq;
>
> spinlock_t lock;
> };
prev parent reply other threads:[~2010-11-13 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-13 18:26 [patch] rtc: jz4740: signedness bug Dan Carpenter
2010-11-13 20:02 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDEEECF.1070709@metafoo.de \
--to=lars@metafoo.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox