From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Date: Fri, 19 Nov 2010 19:01:56 +0000 Subject: Re: [PATCH] power: gpio-charger: fix potential NULL dereference Message-Id: <4CE6C9A4.4090307@metafoo.de> List-Id: References: <1290192114-11659-1-git-send-email-segoon@openwall.com> In-Reply-To: <1290192114-11659-1-git-send-email-segoon@openwall.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasiliy Kulikov Cc: kernel-janitors@vger.kernel.org, Anton Vorontsov , linux-kernel@vger.kernel.org Vasiliy Kulikov wrote: > kzalloc() result is not compared with NULL. It might lead to NULL > pointer dereference in OOM situation. > > Signed-off-by: Vasiliy Kulikov > --- > Compile tested only. > > drivers/power/gpio-charger.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c > index fccbe99..b07a71c 100644 > --- a/drivers/power/gpio-charger.c > +++ b/drivers/power/gpio-charger.c > @@ -87,6 +87,10 @@ static int __devinit gpio_charger_probe(struct platform_device *pdev) > } > > gpio_charger = kzalloc(sizeof(*gpio_charger), GFP_KERNEL); > + if (!gpio_charger) { > + dev_err(&pdev->dev, "kzalloc failed\n"); > + return -ENOMEM; > + } > > charger = &gpio_charger->charger; > Hi I already send a similar patch yesterday. See http://lkml.org/lkml/2010/11/18/632 - Lars