From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Date: Thu, 10 Feb 2011 00:12:17 +0000 Subject: Re: [patch] ext4: off by one check in ext4_groupinfo_create_slab() Message-Id: <4D532D61.7030007@redhat.com> List-Id: References: <20110209232412.GC4384@bicker> In-Reply-To: <20110209232412.GC4384@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Theodore Ts'o , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org On 2/9/11 5:24 PM, Dan Carpenter wrote: > If cache_index = NR_GRPINFO_CACHES then we read past the end of the > ext4_groupinfo_caches[] array a couple lines later. > > Signed-off-by: Dan Carpenter Argh, you'd think I could cut and paste from jbd2 better :( Thanks, Reviewed-by: Eric Sandeen > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 02cff4a..d1fe09a 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -2438,7 +2438,7 @@ static int ext4_groupinfo_create_slab(size_t size) > int cache_index = blocksize_bits - EXT4_MIN_BLOCK_LOG_SIZE; > struct kmem_cache *cachep; > > - if (cache_index > NR_GRPINFO_CACHES) > + if (cache_index >= NR_GRPINFO_CACHES) > return -EINVAL; > > if (unlikely(cache_index < 0)) > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html