From: Sergei Shtylyov <sshtylyov@mvista.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/4] USB: musb: add missing unlock in cppi_interrupt()
Date: Sun, 20 Mar 2011 14:02:03 +0000 [thread overview]
Message-ID: <4D8608DB.2060608@ru.mvista.com> (raw)
In-Reply-To: <20110320111436.GI2008@bicker>
Hello.
On 20-03-2011 14:14, Dan Carpenter wrote:
> We should unlock before returning here.
> Signed-off-by: Dan Carpenter<error27@gmail.com>
> ---
> Compile tested only. Isn't cppi->irq always true at this point?
No. It's only true for DM646x, and false for other DaVincis.
> diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
> index de55a3c..6385eeb 100644
> --- a/drivers/usb/musb/cppi_dma.c
> +++ b/drivers/usb/musb/cppi_dma.c
> @@ -1167,8 +1167,11 @@ irqreturn_t cppi_interrupt(int irq, void *dev_id)
> tx = musb_readl(tibase, DAVINCI_TXCPPI_MASKED_REG);
> rx = musb_readl(tibase, DAVINCI_RXCPPI_MASKED_REG);
>
> - if (!tx && !rx)
> + if (!tx && !rx) {
> + if (cppi->irq)
> + spin_unlock_irqrestore(&musb->lock, flags);
> return IRQ_NONE;
> + }
>
> DBG(4, "CPPI IRQ Tx%x Rx%x\n", tx, rx);
Thanks for fixing this.
WBR, Sergei
next prev parent reply other threads:[~2011-03-20 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 11:14 [patch 1/4] USB: musb: add missing unlock in cppi_interrupt() Dan Carpenter
2011-03-20 14:02 ` Sergei Shtylyov [this message]
2011-03-22 9:21 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8608DB.2060608@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox