[PATCH] x86: smpboot: mark array as const

[PATCH] x86: smpboot: mark array as const

[Greg Dietsche]

This array is read-only. Make it explicit by marking as const.

Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
 arch/x86/kernel/smpboot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 9fd3137..4218569 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -438,7 +438,7 @@ static void impress_friends(void)
 void __inquire_remote_apic(int apicid)
 {
 	unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
-	char *names[] = { "ID", "VERSION", "SPIV" };
+	const char const *names[] = { "ID", "VERSION", "SPIV" };
 	int timeout;
 	u32 status;
 
-- 
1.7.2.5

Re: [PATCH] x86: smpboot: mark array as const

[H. Peter Anvin]

On 06/30/2011 03:31 PM, Greg Dietsche wrote:
> This array is read-only. Make it explicit by marking as const.
> 
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 9fd3137..4218569 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -438,7 +438,7 @@ static void impress_friends(void)
>  void __inquire_remote_apic(int apicid)
>  {
>  	unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
> -	char *names[] = { "ID", "VERSION", "SPIV" };
> +	const char const *names[] = { "ID", "VERSION", "SPIV" };
>  	int timeout;

Did you mean "const char * const" here?

	-hpa

Re: [PATCH] x86: smpboot: mark array as const

[Greg Dietsche]

On Thu, Jun 30, 2011 at 05:23:03PM -0700, H. Peter Anvin wrote:
> On 06/30/2011 03:31 PM, Greg Dietsche wrote:
> > This array is read-only. Make it explicit by marking as const.
> > 
> > Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> > ---
> >  arch/x86/kernel/smpboot.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > index 9fd3137..4218569 100644
> > --- a/arch/x86/kernel/smpboot.c
> > +++ b/arch/x86/kernel/smpboot.c
> > @@ -438,7 +438,7 @@ static void impress_friends(void)
> >  void __inquire_remote_apic(int apicid)
> >  {
> >  	unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
> > -	char *names[] = { "ID", "VERSION", "SPIV" };
> > +	const char const *names[] = { "ID", "VERSION", "SPIV" };
> >  	int timeout;
> 
> Did you mean "const char * const" here?
doh! Yes, i did! Sorry I missed this email the first time around - my
procmail rules need a little work....

Greg

> 	-hpa
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>