From mboxrd@z Thu Jan  1 00:00:00 1970
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Fri, 01 Jul 2011 00:23:03 +0000
Subject: Re: [PATCH] x86: smpboot: mark array as const
Message-Id: <4E0D1367.5020008@zytor.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1309473108-5337-1-git-send-email-Gregory.Dietsche@cuw.edu>
In-Reply-To: <1309473108-5337-1-git-send-email-Gregory.Dietsche@cuw.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On 06/30/2011 03:31 PM, Greg Dietsche wrote:
> This array is read-only. Make it explicit by marking as const.
> 
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 9fd3137..4218569 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -438,7 +438,7 @@ static void impress_friends(void)
>  void __inquire_remote_apic(int apicid)
>  {
>  	unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
> -	char *names[] = { "ID", "VERSION", "SPIV" };
> +	const char const *names[] = { "ID", "VERSION", "SPIV" };
>  	int timeout;

Did you mean "const char * const" here?

	-hpa