* [PATCH v2] x86: smpboot: mark array as const
@ 2011-07-01 1:10 Greg Dietsche
2011-07-20 2:03 ` Greg Dietsche
0 siblings, 1 reply; 2+ messages in thread
From: Greg Dietsche @ 2011-07-01 1:10 UTC (permalink / raw)
To: kernel-janitors
This array is read-only. Make it explicit by marking as const.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
arch/x86/kernel/smpboot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 9fd3137..9f548cb 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -438,7 +438,7 @@ static void impress_friends(void)
void __inquire_remote_apic(int apicid)
{
unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
- char *names[] = { "ID", "VERSION", "SPIV" };
+ const char * const names[] = { "ID", "VERSION", "SPIV" };
int timeout;
u32 status;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] x86: smpboot: mark array as const
2011-07-01 1:10 [PATCH v2] x86: smpboot: mark array as const Greg Dietsche
@ 2011-07-20 2:03 ` Greg Dietsche
0 siblings, 0 replies; 2+ messages in thread
From: Greg Dietsche @ 2011-07-20 2:03 UTC (permalink / raw)
To: kernel-janitors
On 06/30/2011 08:10 PM, Greg Dietsche wrote:
> This array is read-only. Make it explicit by marking as const.
>
> Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
> ---
> arch/x86/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 9fd3137..9f548cb 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -438,7 +438,7 @@ static void impress_friends(void)
> void __inquire_remote_apic(int apicid)
> {
> unsigned i, regs[] = { APIC_ID>> 4, APIC_LVR>> 4, APIC_SPIV>> 4 };
> - char *names[] = { "ID", "VERSION", "SPIV" };
> + const char * const names[] = { "ID", "VERSION", "SPIV" };
> int timeout;
> u32 status;
>
>
adding trivial@kernel.org to the cc list since this is trivial and no
one has picked up this patch to date.
Greg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-20 2:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-01 1:10 [PATCH v2] x86: smpboot: mark array as const Greg Dietsche
2011-07-20 2:03 ` Greg Dietsche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).