From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON
Date: Thu, 04 Aug 2011 07:13:21 +0000 [thread overview]
Message-ID: <4E3A4691.6060009@bfs.de> (raw)
In-Reply-To: <1312281304-11847-3-git-send-email-julia@diku.dk>
Am 04.08.2011 08:54, schrieb Nandigama, Nagalakshmi:
> The patch seem to be fine. Please consider this patch as an Acked by me
>
> Regards,
> Nagalakshmi
Hi Nagalakshmi,
nice try :) when you want to acknowledge a patch you should write:
Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Otherwise scripts that look for an acknowledge have a hard time.
re,
wh
>
>
> -----Original Message-----
> From: Julia Lawall [mailto:julia@diku.dk]
> Sent: Tuesday, August 02, 2011 4:05 PM
> To: Moore, Eric; trivial@kernel.org
> Cc: kernel-janitors@vger.kernel.org; Support; DL-MPT Fusion Linux; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON
>
> From: Julia Lawall <julia@diku.dk>
>
> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
>
> @@ identifier x; @@
> -if (!x) BUG();
> +BUG_ON(!x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/message/fusion/mptsas.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -3410,8 +3410,7 @@ mptsas_expander_event_add(MPT_ADAPTER *i
> __le64 sas_address;
>
> port_info = kzalloc(sizeof(struct mptsas_portinfo), GFP_KERNEL);
> - if (!port_info)
> - BUG();
> + BUG_ON(!port_info);
> port_info->num_phys = (expander_data->NumPhys) ?
> expander_data->NumPhys : 1;
> port_info->phy_info = kcalloc(port_info->num_phys,
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2011-08-04 7:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 10:34 [PATCH 0/11] trivial: use BUG_ON Julia Lawall
2011-08-02 10:34 ` [PATCH 1/11] kernel/kfifo.c: " Julia Lawall
2011-08-02 11:33 ` Andrea Righi
2011-08-02 11:52 ` Julia Lawall
2011-08-02 12:03 ` Andrea Righi
2011-08-02 15:20 ` Julia Lawall
2011-08-02 19:27 ` Julia Lawall
2011-08-02 20:09 ` Andrea Righi
2011-08-03 6:30 ` Stefani Seibold
2011-08-02 10:34 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: " Julia Lawall
2011-08-04 6:54 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use Nandigama, Nagalakshmi
2011-08-04 7:13 ` walter harms [this message]
2011-08-02 10:34 ` [PATCH 3/11] arch/arm/mach-s3c64xx/dma.c: trivial: use BUG_ON Julia Lawall
2011-08-02 10:34 ` [PATCH 4/11] arch/x86/kvm/vmx.c: " Julia Lawall
2011-08-02 16:44 ` Marcelo Tosatti
2011-08-02 10:34 ` [PATCH 5/11] kernel/sysctl.c: " Julia Lawall
2011-08-02 10:34 ` [PATCH 6/11] drivers/iommu/iommu.c: " Julia Lawall
2011-08-02 10:35 ` [PATCH 7/11] arch/m32r/kernel/smp.c: " Julia Lawall
2011-08-02 10:55 ` KOSAKI Motohiro
2011-08-02 10:35 ` [PATCH 8/11] fs/btrfs/volumes.c: " Julia Lawall
2011-08-02 10:35 ` [PATCH 9/11] drivers/target/target_core_rd.c: " Julia Lawall
2011-08-04 18:05 ` [PATCH 9/11] drivers/target/target_core_rd.c: trivial: use Nicholas A. Bellinger
2011-08-02 10:35 ` [PATCH 10/11] arch/openrisc/mm/init.c: trivial: use BUG_ON Julia Lawall
2011-08-02 13:55 ` Jonas Bonn
2011-08-02 10:35 ` [PATCH 11/11] arch/tile/mm/init.c: " Julia Lawall
2011-08-02 20:28 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3A4691.6060009@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox